Closed
Conversation
Contributor
|
Not libxml2 is failing. The port cmake is failing as a depent of libxml2 since it does not know that libxml2 has been linked with iconv. The vcpkg-cmake-wrapper needs to be adjusted to reflect that libxml2 has been build with iconv. This is already done for Windows but not for osx. Just take a look into libxml2 vcpkg-cmake-wrapper and you should directly see it |
Contributor
Author
|
Thanks for your update. |
Contributor
Author
|
After further investigation about this, it seems that this is not a bug for libxml2. So I close this PR now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
llibxml2 failed on osx pipeline in the PR #10770
I checked the CMakeLists.txt and found that iconv has been linked. And I also cannot reproduce this on my local.
Related issue #11001.